Skip to content

docker: simplify the docker name with CUDA #21001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 11, 2025
Merged

docker: simplify the docker name with CUDA #21001

merged 2 commits into from
Aug 11, 2025

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Jul 25, 2025 •
edited by github-actions bot
Loading

What does this PR do?

dont duplicate the CUDA in the name so with next lit CI the name is shorter

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21001.org.readthedocs.build/en/21001/

@github-actions github-actions bot added ci Continuous Integration dockers labels Jul 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docker
Check ID Status
build-cuda (3.10, 2.1.2, 12.1.1) success ✅
build-cuda (3.11, 2.2.2, 12.1.1) success ✅
build-cuda (3.11, 2.3.1, 12.1.1) success ✅
build-cuda (3.11, 2.4.1, 12.1.1) success ✅
build-cuda (3.12, 2.5.1, 12.1.1) success ✅
build-cuda (3.12, 2.6.0, 12.4.1) success ✅
build-pl (3.10, 2.1, 12.1.1) success ✅
build-pl (3.11, 2.2, 12.1.1) success ✅
build-pl (3.11, 2.3, 12.1.1) success ✅
build-pl (3.11, 2.4, 12.1.1) success ✅
build-pl (3.12, 2.5, 12.1.1) success ✅
build-pl (3.12, 2.6, 12.4.1) success ✅
build-pl (3.12, 2.7, 12.6.3, true) success ✅

These checks are required after the changes to .github/workflows/docker-build.yml.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@lantiga lantiga merged commit f067626 into master Aug 11, 2025
28 checks passed
@lantiga lantiga deleted the docker/cuda branch August 11, 2025 15:26
Borda added a commit that referenced this pull request Aug 13, 2025
@Borda @bhimrazy
docker: simplify the docker name with CUDA (#21001)
722e1af 
Co-authored-by: Bhimraj Yadav <[email protected]>
(cherry picked from commit f067626)
Borda added a commit that referenced this pull request Aug 13, 2025
@Borda @bhimrazy
docker: simplify the docker name with CUDA (#21001)
e4f79d7 
Co-authored-by: Bhimraj Yadav <[email protected]>
(cherry picked from commit f067626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lantiga lantiga lantiga approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@bhimrazy bhimrazy bhimrazy approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

Assignees

No one assigned

Labels

ci Continuous Integration dockers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Borda @lantiga @SkafteNicki @bhimrazy